fix(mermaid): make mermaid render client-side#121
Merged
toumorokoshi merged 2 commits intoaep-dev:mainfrom Mar 1, 2026
Merged
Conversation
playwright is a pretty heavy build-time dependency, increasing the complexity of rendering and development. This dependency only exists for mermaid's server-side rendering. Replacing it with a light client-side rendering approach instead. Although this means that the diagrams will no longer be SVGs and some javascript will be required, this also enables improvements like having the mermaid diagram honor the light/dark settings. So arguing that it is worth the tradeoffs.
rambleraptor
approved these changes
Mar 1, 2026
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Ideally, we'd be able to create a Mermaid component that bakes in the logic being placed into Head.
That being said, I think this will be fine as is.
Member
Author
Yeah I thought about that. Maybe I can see if we can inject it somehow via the plugin at least? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
playwright is a pretty heavy build-time dependency, increasing the complexity of rendering and development.
This dependency only exists for mermaid's server-side rendering. Replacing it with a light client-side rendering approach instead.
Although this means that the diagrams will no longer be SVGs and some javascript will be required, this also enables improvements like having the mermaid diagram honor the light/dark settings. So arguing that it is worth the tradeoffs.