fix(tools): do not include resource in the tools payload#11
Merged
toumorokoshi merged 1 commit intoaep-dev:mainfrom May 13, 2025
Merged
Conversation
Including the full resources in the tools payload results in an
extremely large resource size, which causes the mcp server
response to time out (e.g. with this example from claude-desktop):
```
2025-05-12T05:04:56.699Z [bookstore] [info] Message from client: {"jsonrpc":"2.0","method":"notifications/cancelled","params":{"requestId":1,"reason":"Error: MCP error -32001: Request timed out"}}
```
The fix is to remove the resource from the payload, and map the tool
to the request another way.
rambleraptor
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including the full resources in the tools payload results in an extremely large resource size, which causes the mcp server response to time out (e.g. with this example from claude-desktop):
The fix is to remove the resource from the payload, and map the tool to the request another way.