Skip to content

fix: supporting remote schema references#10

Merged
toumorokoshi merged 1 commit intoaep-dev:mainfrom
toumorokoshi:yft/deref-schema
May 12, 2025
Merged

fix: supporting remote schema references#10
toumorokoshi merged 1 commit intoaep-dev:mainfrom
toumorokoshi:yft/deref-schema

Conversation

@toumorokoshi
Copy link
Copy Markdown
Member

The new example API for aeps have remote schemas
available a HTTP urls - this allows those to be
dereferenced.

The new example API for aeps have remote schemas 
available a HTTP urls - this allows those to be 
dereferenced.
Copy link
Copy Markdown
Member

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've tested this with Claude and/or the Inspector right? Some forms of logging print to stdout and break the server protocol completely.

There's a special logging library in the MCP docs but I like the Winston interface more.

tools: tools
}));
server.setRequestHandler(ListToolsRequestSchema, async () => {
// logger.info("Received list tools request");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this if we don't want to comment it.

@toumorokoshi
Copy link
Copy Markdown
Member Author

You've tested this with Claude and/or the Inspector right? Some forms of logging print to stdout and break the server protocol completely.

There's a special logging library in the MCP docs but I like the Winston interface more.

Yep! Yeah I figured out logging breaking the server the hard way 😓 Note the switch to logging to stderr in winston.

But i'll add a comment - it's a good thing to clarify.

@toumorokoshi toumorokoshi merged commit 84d58c2 into aep-dev:main May 12, 2025
1 check passed
@toumorokoshi
Copy link
Copy Markdown
Member Author

verified the bookstore issue I was having was unrelated - fix incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants