Skip to content

fix(openapi): correct Create/Apply HTTP response codes#15

Merged
toumorokoshi merged 1 commit intoaep-dev:mainfrom
thegagne:fix/create-apply-response-codes
Mar 30, 2026
Merged

fix(openapi): correct Create/Apply HTTP response codes#15
toumorokoshi merged 1 commit intoaep-dev:mainfrom
thegagne:fix/create-apply-response-codes

Conversation

@thegagne
Copy link
Copy Markdown
Contributor

Summary

  • Create (POST) now returns 201 Created instead of 200 OK, per RFC 7231 §4.3.3
  • Apply (PUT) now returns both 200 OK (updated) and 201 Created (created)

This corrects an oversight from the aep-2026 release. Corresponding guidance changes are in aep-dev/aeps#406.

Test plan

  • Verify generated OAS for Create operations shows 201 response
  • Verify generated OAS for Apply operations shows both 200 and 201 responses
  • Confirm Get/Update/Delete response codes are unchanged

Create (POST) must return 201 Created per RFC 7231. Apply (PUT) must
return 201 when creating a resource and 200 when updating.
Copy link
Copy Markdown
Member

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided we all agree on the spec change, this sounds great.

Copy link
Copy Markdown
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toumorokoshi toumorokoshi merged commit 6d92f20 into aep-dev:main Mar 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants