-
Notifications
You must be signed in to change notification settings - Fork 237
[DOC] Add Shapelets Transformer Documentation (Issue #3028) #3139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[DOC] Add Shapelets Transformer Documentation (Issue #3028) #3139
Conversation
Thank you for contributing to
|
|
Thanks for this, pinging @baraline here, i think the placement should be inside the transformer api no ? |
|
Hi, the file you created doesn't follow the existing project structure
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
baraline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a new RDST transformer file it already exists.
The following files should be deleted and the content of _rdst.py merged with the documentation of the existing RDST transformer.
aeon/transformations/collection/convolutional/__init__.py
aeon/transformations/collection/convolutional/_rdst.py
You don't need to create the shapelets.md file either. Please refer to the aeon documentation on this matter if you are not sure how to add documentation.
The notebook also seem to be failing to run according to the tests.
This PR adds comprehensive documentation for RDST shapelets, including: