Skip to content

test(zigux): add phase1 bench checker self-test contract#15428

Merged
adybag14-cyber merged 1 commit into
masterfrom
zigux-builder/lane16-bench-checker-selftest-contract-20260529t1738z-r2
Jun 1, 2026
Merged

test(zigux): add phase1 bench checker self-test contract#15428
adybag14-cyber merged 1 commit into
masterfrom
zigux-builder/lane16-bench-checker-selftest-contract-20260529t1738z-r2

Conversation

@adybag14-cyber
Copy link
Copy Markdown
Owner

Summary

  • add zigux/tests/phase1_bench_checker_selftest_contract.zig as a Zig-facing Lane 16 contract for the current Phase 1 bench checker self-test surface
  • assert the checker keeps the --self-test CLI, success/count packet, source-drift validation buckets, rbtree cached checksum marker, malformed JSON diagnostics, and fail-closed expectation/output diagnostics visible
  • keep the change additive and disjoint from the existing bench build, output, and replay runner fronts

Why This Lane

  • Lane 16 owns Phase 1 hardening gates around bench-sensitive helper packets
  • recent Lane 16 work has hardened the bench body, build route, output packet, and many replay runners; this adds a non-overlapping guard for the checker self-test contract itself
  • this avoids touching scripts/zigux/check-phase1-bench.py, zigux/tests/phase1_bench.zig, zigux/tests/phase1_bench_build.zig, fixtures, docs, workflows, or shared test wiring

Validation

  • authenticated current-master read grounded scripts/zigux/check-phase1-bench.py at blob 407ec44c8a4ff7bfcc2c35b43703b7b75f5b7779
  • authenticated current-master read confirmed zigux/tests/phase1_bench_checker_selftest_contract.zig returned 404 before publication
  • direct live checkout remains unavailable in this scheduled runtime, so focused validation used the attached Zigux-master.zip scaffold plus attached Zig 0.17.0-dev.87+9b177a7d2
  • local validation refreshed only the bench checker source to the authenticated current-master shape before running the new Zig contract
  • zig fmt --check zigux/tests/phase1_bench_checker_selftest_contract.zig
  • zig test zigux/tests/phase1_bench_checker_selftest_contract.zig
    • result: All 3 tests passed.
  • master advanced during publication; the branch was restacked onto current master aef378a3226859808acd6dfeeb98960fbe4b2bdf
  • authenticated final compare against current master:
    • changed files: zigux/tests/phase1_bench_checker_selftest_contract.zig
    • result: ahead_by: 1
    • result: behind_by: 0
    • result: status: ahead
    • head: 6d879c4ec2c4da3e31d4b4dbc24042b470742240

Scope

Coordination

Validation Boundary

Direct live checkout remains blocked by the scheduled runtime network policy, so repo grounding and publication used authenticated GitHub reads/writes plus focused scratch validation.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70d5660c-f531-4d04-b5ed-da2228982c88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch zigux-builder/lane16-bench-checker-selftest-contract-20260529t1738z-r2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adybag14-cyber adybag14-cyber merged commit 6d879c4 into master Jun 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant