Skip to content

test(zigux): add lane16 list_sort bench replay#13027

Closed
adybag14-cyber wants to merge 2 commits into
masterfrom
zigux-builder/lane16-list-sort-bench-replay-current-master-20260528t0055z
Closed

test(zigux): add lane16 list_sort bench replay#13027
adybag14-cyber wants to merge 2 commits into
masterfrom
zigux-builder/lane16-list-sort-bench-replay-current-master-20260528t0055z

Conversation

@adybag14-cyber
Copy link
Copy Markdown
Owner

Summary

  • add zigux/tests/phase1_list_sort_bench_replay.zig as a standalone Lane 16 replay for the list_sort packet from zigux/tests/phase1_bench.zig
  • keep the pass one-file scoped to the stable ordering witness and the exact 1000-iteration checksum contract
  • land real .zig progress without reopening zigux/tests/build.zig, scripts/zigux/check-phase1-bench.py, or the active Lane 16 rbtree and checker fronts

Why This Lane

  • Lane 16 owns the bounded Phase 1 hardening-gates slice around the bench-sensitive helper packets
  • fresh same-lane review paths already cover the find_bit edge packet and several rbtree bench packets, but the list_sort bench packet still lacked its own standalone tests-root witness on current master
  • a new one-file replay is the smallest honest non-overlapping move because it strengthens the live Phase 1 bench surface while staying additive and helper-local to the tests root

Validation

  • exact current-master reread confirmed zigux/tests/phase1_list_sort_bench_replay.zig returned 404 Not Found before publication
  • exact current-helper reread grounded the replay against live tools/lib/list_sort.zig blob 1cfde887dbd6bfaa5b1e4dec6948075a58c57e78
  • focused scratch validation used the attached repo archive plus the attached Zig 0.17.0-dev.87+9b177a7d2 toolchain because this runtime still could not open a trustworthy live checkout of adybag14-cyber/Zigux
  • zig fmt --check zigux/tests/phase1_list_sort_bench_replay.zig
  • zig test --dep list_sort -Mroot=zigux/tests/phase1_list_sort_bench_replay.zig -Mlist_sort=tools/lib/list_sort.zig -O ReleaseSafe
    • result: All 2 tests passed.

Scope

  • lane: Lane 16 — Phase 1 hardening gates
  • session issue: #13023
  • branch: zigux-builder/lane16-list-sort-bench-replay-current-master-20260528t0055z
  • file:
    • zigux/tests/phase1_list_sort_bench_replay.zig
  • intentionally no edits to tools/lib/list_sort.zig, zigux/tests/build.zig, scripts/zigux/check-phase1-bench.py, or the separate Lane 16 checker and replay fronts

Coordination

  • keep draft PR #12959 as the separate rbtree postorder bench replay frontier
  • keep draft PR #12902 as the separate rbtree duplicate-mutation bench replay frontier
  • keep draft PR #12850 as the separate rbtree findAdd(...) replay frontier
  • keep draft PR #12794 as the separate rbtree duplicate-range replay frontier
  • keep draft PR #12743 as the separate find_bit edge replay frontier
  • keep draft PR #12638 as the separate cached-root replay runner frontier
  • keep draft PR #12566 as the separate rbtree bench guard frontier
  • keep draft PR #12459 as the separate reminder-packet-members checker frontier
  • keep draft PR #11790 as the separate historical gap-packet frontier
  • keep draft PR #11043 as the separate current-bench-packet checker frontier
  • keep draft PR #2203 as the separate bench-reminder checker path
  • keep draft PR #2022 as the separate closure-gates workflow path

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d8a3d38-c109-4d2d-b893-1b2c60e30a97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch zigux-builder/lane16-list-sort-bench-replay-current-master-20260528t0055z

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

Superseded by current-master draft PR #14450, which carries the same Lane 16 list_sort bench replay plus the dedicated phase1_list_sort_bench_replay_build.zig runner. I also briefly added the runner on this older branch during the follow-up, but the branch is now substantially behind master, so #14450 is the cleaner review path.

@adybag14-cyber adybag14-cyber deleted the zigux-builder/lane16-list-sort-bench-replay-current-master-20260528t0055z branch June 2, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant