Skip to content

feat(phase10): decide virtio net refill notifications#12615

Draft
adybag14-cyber wants to merge 3 commits into
zigux-builder/p7-l14-refill-descriptor-budget-20260525T1225Zfrom
zigux-builder/p7-l14-refill-notify-decision-20260527T1238Z
Draft

feat(phase10): decide virtio net refill notifications#12615
adybag14-cyber wants to merge 3 commits into
zigux-builder/p7-l14-refill-descriptor-budget-20260525T1225Zfrom
zigux-builder/p7-l14-refill-notify-decision-20260527T1238Z

Conversation

@adybag14-cyber
Copy link
Copy Markdown
Owner

Summary

  • add a bounded decideReceiveQueueRefillNotify() helper to drivers/net/virtio_net.zig so the existing refill reservation plan can be turned into one queue-local notify decision without entering descriptor writes or queue kicks
  • extend zigux/tests/phase10_virtio_net.zig with focused coverage for empty-queue transitions, descriptor-threshold notifications, suppressed notifications, and zero-descriptor reservations
  • refresh Documentation/zigux/phase10-virtio-net-slice.md so the lane note records the new notify-decision boundary

Why this lane

  • the schedule prompt still names Phase 7, but current repo reality and prior P7-L14 work keep this lane narrowed to the existing Phase 10 virtio_net lab-driver packet
  • the previous same-lane step on draft PR #10600 already reserved one refill pass against available receive-queue descriptors
  • the next bounded, non-overlapping move in that same family was to consume that reservation plan for a queue-local notify decision without widening into live descriptor writes, DMA submission, queue kicks, receive completion, NAPI, or netdev lifecycle work

Validation

  • zig fmt --check drivers/virtio/virtio.zig drivers/net/virtio_net.zig zigux/tests/phase10_virtio_net.zig zigux/tests/phase10_build.zig
  • cd zigux/tests && zig build phase10-virtio-net-tests --build-file phase10_build.zig --summary all
    • result: Build Summary: 3/3 steps succeeded; 7/7 tests passed

Scope

  • lane: P7-L14, narrowed to the existing Phase 10 virtio_net packet
  • base branch: zigux-builder/p7-l14-refill-descriptor-budget-20260525T1225Z
  • files:
    • drivers/net/virtio_net.zig
    • zigux/tests/phase10_virtio_net.zig
    • Documentation/zigux/phase10-virtio-net-slice.md
  • intentionally no edits to drivers/virtio/virtio.zig, shared Phase 10 build wiring, DMA paths, live kicks, NAPI, or receive-completion code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8deae8a1-95be-4f0b-8d05-a968582c8216

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch zigux-builder/p7-l14-refill-notify-decision-20260527T1238Z

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant