feat(phase10): decide virtio net refill notifications#12615
Draft
adybag14-cyber wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decideReceiveQueueRefillNotify()helper todrivers/net/virtio_net.zigso the existing refill reservation plan can be turned into one queue-local notify decision without entering descriptor writes or queue kickszigux/tests/phase10_virtio_net.zigwith focused coverage for empty-queue transitions, descriptor-threshold notifications, suppressed notifications, and zero-descriptor reservationsDocumentation/zigux/phase10-virtio-net-slice.mdso the lane note records the new notify-decision boundaryWhy this lane
P7-L14work keep this lane narrowed to the existing Phase 10virtio_netlab-driver packet#10600already reserved one refill pass against available receive-queue descriptorsValidation
zig fmt --check drivers/virtio/virtio.zig drivers/net/virtio_net.zig zigux/tests/phase10_virtio_net.zig zigux/tests/phase10_build.zigcd zigux/tests && zig build phase10-virtio-net-tests --build-file phase10_build.zig --summary allBuild Summary: 3/3 steps succeeded; 7/7 tests passedScope
P7-L14, narrowed to the existing Phase 10virtio_netpacketzigux-builder/p7-l14-refill-descriptor-budget-20260525T1225Zdrivers/net/virtio_net.zigzigux/tests/phase10_virtio_net.zigDocumentation/zigux/phase10-virtio-net-slice.mddrivers/virtio/virtio.zig, shared Phase 10 build wiring, DMA paths, live kicks, NAPI, or receive-completion code