Skip to content

test(scripts/zigux): add lane14 same-class trailing not-elf replay#12118

Draft
adybag14-cyber wants to merge 3 commits into
zigux-builder/lane14-trailing-same-class-hide-current-master-20260526t0235zfrom
zigux-builder/lane14-trailing-same-class-not-elf-hide-current-20260527t0001z
Draft

test(scripts/zigux): add lane14 same-class trailing not-elf replay#12118
adybag14-cyber wants to merge 3 commits into
zigux-builder/lane14-trailing-same-class-hide-current-master-20260526t0235zfrom
zigux-builder/lane14-trailing-same-class-not-elf-hide-current-20260527t0001z

Conversation

@adybag14-cyber
Copy link
Copy Markdown
Owner

Summary

  • add scripts/zigux/mk_elfconfig_fd_trailing_same_class_not_elf_hides_following_not_elf_test.zig as a fresh standalone Lane 14 fd replay on a new filename
  • add scripts/zigux/check-mk-elfconfig-fd-trailing-same-class-not-elf-hides-following-not-elf-markers.py so the packet fails closed if its two same-class trailing not ELF tests drift or disappear
  • keep the change additive and off the large mk_elfconfig.zig helper body while the lane still prefers fresh standalone fd packets in no-checkout runs

Why This Lane

  • Lane 14 still owns the bounded Phase 2 mk_elfconfig helper tranche from the roadmap and bootstrap ledger
  • the lane already had same-class trailing-hide siblings for ELF headers and invalid-class headers, but it still lacked the matching same-class not ELF sibling on a clean filename
  • this keeps the work .zig-first, lands real same-lane progress, and avoids widening into docs, workflow, fixture, or helper-body write sets

Validation

  • scratch replay used the active Lane 14 helper body plus the attached Zig toolchain 0.17.0-dev.87+9b177a7d2
  • zig fmt --check /workspace/.scratch/lane14_same_class_not_elf/scripts/zigux/mk_elfconfig_fd_trailing_same_class_not_elf_hides_following_not_elf_test.zig
  • cd /workspace/.scratch/lane14_same_class_not_elf/scripts/zigux && zig test mk_elfconfig_fd_trailing_same_class_not_elf_hides_following_not_elf_test.zig
    • result: All 33 tests passed.
  • python3 -m py_compile /workspace/.scratch/lane14_same_class_not_elf/scripts/zigux/check-mk-elfconfig-fd-trailing-same-class-not-elf-hides-following-not-elf-markers.py
  • cd /workspace/.scratch/lane14_same_class_not_elf && python3 scripts/zigux/check-mk-elfconfig-fd-trailing-same-class-not-elf-hides-following-not-elf-markers.py --self-test
    • result: MK_ELFCONFIG_FD_TRAILING_SAME_CLASS_NOT_ELF_HIDES_FOLLOWING_NOT_ELF_MARKERS_SELF_TEST=pass
    • result: MK_ELFCONFIG_FD_TRAILING_SAME_CLASS_NOT_ELF_HIDES_FOLLOWING_NOT_ELF_MARKERS_SELF_TEST_CASE_COUNT=4
  • cd /workspace/.scratch/lane14_same_class_not_elf && python3 scripts/zigux/check-mk-elfconfig-fd-trailing-same-class-not-elf-hides-following-not-elf-markers.py
    • result: MK_ELFCONFIG_FD_TRAILING_SAME_CLASS_NOT_ELF_HIDES_FOLLOWING_NOT_ELF_MARKERS=pass
    • result: MK_ELFCONFIG_FD_TRAILING_SAME_CLASS_NOT_ELF_HIDES_FOLLOWING_NOT_ELF_MARKERS_COUNT=2

Scope

  • lane: Lane 14 — Phase 2 mk_elfconfig lane
  • session issue: #12116
  • branch: zigux-builder/lane14-trailing-same-class-not-elf-hide-current-20260527t0001z
  • files:
    • scripts/zigux/mk_elfconfig_fd_trailing_same_class_not_elf_hides_following_not_elf_test.zig
    • scripts/zigux/check-mk-elfconfig-fd-trailing-same-class-not-elf-hides-following-not-elf-markers.py
  • intentionally no edits to scripts/zigux/mk_elfconfig.zig, shared fixtures, .github/workflows/zigux-bootstrap.yml, docs, or zigux/Makefile

Coordination

  • base this review on draft PR #11364 because that branch already carries the same-class trailing ELF sibling this packet complements
  • compare zigux-builder/lane14-trailing-same-class-hide-current-master-20260526t0235z...zigux-builder/lane14-trailing-same-class-not-elf-hide-current-20260527t0001z
    • result: changed files remain exactly the two new packet files
    • result: ahead_by: 3
    • result: behind_by: 0
    • result: status: ahead
  • the next honest merge-path follow-through is to fold this packet into the broader Lane 14 current-master line after the sibling review surface is accepted, not to widen into a helper rewrite here

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fb39115c-8b93-4fc6-bb0b-1034f7482f63

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch zigux-builder/lane14-trailing-same-class-not-elf-hide-current-20260527t0001z

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant