Skip to content

Performance optimization adding styles #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjensenbloom wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Performance optimization adding styles #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a176cdf
Optimize createStyle
jjensenbloom Jul 23, 2024
bf07804
Remove blank line
jjensenbloom Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/lib/workbook/workbook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,13 +238,14 @@ class Workbook {
* @returns {Style}
*/
createStyle(opts) {
const thisStyle = new Style(this, opts);
const lookupKey = JSON.stringify(thisStyle.toObject());
const lookupKey = JSON.stringify(opts);

// Use existing style if one exists
if (this.stylesLookup.get(lookupKey)) {
return this.stylesLookup.get(lookupKey);
}

const thisStyle = new Style(this, opts);

this.stylesLookup.set(lookupKey, thisStyle);
const index = this.styles.push(thisStyle) - 1;
Expand Down Expand Up @@ -279,4 +280,4 @@ class Workbook {
}
}

module.exports = Workbook;
module.exports = Workbook;