Skip to content

Do some silly changes to introduce vulns in a few projects #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do some silly changes to introduce vulns in a few projects #8

wants to merge 1 commit into from

Conversation

felickz
Copy link
Contributor

@felickz felickz commented Mar 7, 2025

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 7, 2025
View reviewed changes
packages/babel-cli/src/babel/dir.ts
function insecurePassword(): string {
// BAD: the random suffix is not cryptographically secure
const suffix = Math.random();
const password = "myPassword" + suffix;

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 7 months ago

To fix the problem, we need to replace the use of Math.random() with a cryptographically secure random number generator. In Node.js, we can use the crypto module's randomBytes method to generate secure random values. We will convert these bytes to a number and use it as the suffix for the password.

  • Import the crypto module.
  • Replace the Math.random() call with a secure random number generation using crypto.randomBytes.
  • Ensure the generated random number is in the desired range.
Suggested changeset 1
packages/babel-cli/src/babel/dir.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/babel-cli/src/babel/dir.ts b/packages/babel-cli/src/babel/dir.ts
--- a/packages/babel-cli/src/babel/dir.ts
+++ b/packages/babel-cli/src/babel/dir.ts
@@ -3,3 +3,3 @@
 import fs from "fs";
-
+import crypto from "crypto";
 import * as util from "./util.ts";
@@ -21,4 +21,4 @@
 function insecurePassword(): string {
-  // BAD: the random suffix is not cryptographically secure
-  const suffix = Math.random();
+  // GOOD: the random suffix is cryptographically secure
+  const suffix = crypto.randomBytes(4).readUInt32BE(0);
   const password = "myPassword" + suffix;
EOF
@@ -3,3 +3,3 @@
import fs from "fs";

import crypto from "crypto";
import * as util from "./util.ts";
@@ -21,4 +21,4 @@
function insecurePassword(): string {
// BAD: the random suffix is not cryptographically secure
const suffix = Math.random();
// GOOD: the random suffix is cryptographically secure
const suffix = crypto.randomBytes(4).readUInt32BE(0);
const password = "myPassword" + suffix;
Copilot is powered by AI and may make mistakes. Always verify output.
packages/babel-helpers/src/index.ts
function insecurePassword(): string {
// BAD: the random suffix is not cryptographically secure
const suffix = Math.random();
const password = "myPassword" + suffix;

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.

Copilot Autofix

AI 7 months ago

To fix the problem, we need to replace the use of Math.random() with a cryptographically secure random number generator. In a Node.js environment, we can use the crypto module's randomBytes method to generate a secure random number. This method provides cryptographically strong pseudo-random data.

We will:

  1. Import the crypto module.
  2. Replace the Math.random() call with a call to crypto.randomBytes.
  3. Convert the random bytes to a number or string that can be appended to the password.
Suggested changeset 1
packages/babel-helpers/src/index.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/babel-helpers/src/index.ts b/packages/babel-helpers/src/index.ts
--- a/packages/babel-helpers/src/index.ts
+++ b/packages/babel-helpers/src/index.ts
@@ -4,2 +4,3 @@
 import type { HelperMetadata } from "./helpers-generated.ts";
+import { randomBytes } from "crypto";
 
@@ -27,4 +28,4 @@
 function insecurePassword(): string {
-  // BAD: the random suffix is not cryptographically secure
-  const suffix = Math.random();
+  // GOOD: the random suffix is cryptographically secure
+  const suffix = randomBytes(4).toString('hex');
   const password = "myPassword" + suffix;
EOF
@@ -4,2 +4,3 @@
import type { HelperMetadata } from "./helpers-generated.ts";
import { randomBytes } from "crypto";

@@ -27,4 +28,4 @@
function insecurePassword(): string {
// BAD: the random suffix is not cryptographically secure
const suffix = Math.random();
// GOOD: the random suffix is cryptographically secure
const suffix = randomBytes(4).toString('hex');
const password = "myPassword" + suffix;
Copilot is powered by AI and may make mistakes. Always verify output.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felickz @Copilot