Add UI5 web app detection #66
Merged
+828
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvermeulen
force-pushed
the
rvermeulen/ui5-bootstrap-detection
branch
from
fa8d8a8 to
d57bb93
Compare
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Outdated
Show resolved
Hide resolved
rvermeulen
force-pushed
the
rvermeulen/ui5-bootstrap-detection
branch
from
0077a0b to
a5fe10f
Compare
We have discovered XML views that have the namespace `sap.ui.core` instead of the documented `sap.ui.core.mvc`. To detect these XML views we now include root elements with: - the name `View`, and - a namespace `sap.ui.core.mvc`, or `sap.ui.core`, but with a namespace declaration for `sap.ui.core.mvc`.
Project resolution relied on a property that doesn't hold for all SAP UI5 projects. The WebApp approach follows the bootstrapping process to determine the definition of a webapp and uses the resource roots to resolve resources beloning to a webapp.
rvermeulen
force-pushed
the
rvermeulen/ui5-bootstrap-detection
branch
2 times, most recently
from
efddae4 to
3edb117
Compare
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/JsonParser.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Show resolved
Hide resolved
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5HTML.qll
Outdated
Show resolved
Hide resolved
|
It's a huge advancement! Some suggestions left above, and after those are done it's a solid 🚀 |
Removing the the forward slash ensures we can find the core script located in the same directoryy as the webapp.
jeongsoolee09
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how we detect a UI5 project.
The used
ui5.ymlfile is part of a tool chain recommended to build UI5 web apps, but is not necessary.We therefore rely on detection of UI5 bootstrapping to determine a web app and its resources.