Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'log-injection-single-file' #166

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jeongsoolee09
Copy link
Contributor

This test case was introduced when the CAP log injection query it intends to test was at its early stage of development. This case is now obsolete since:

  • It lacks a comprehensive structure of a CAP application (with package.json and a .cds file accompanying the .js file), which makes it unsuitable for testing production-grade CAP queries, and
  • There are a lot of other test cases that already have the structure and serves the same purpose as this file's.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • javascript/frameworks/cap/test/queries/loginjection/log-injection-single-file/loginjection.expected: Language not supported
  • javascript/frameworks/cap/test/queries/loginjection/log-injection-single-file/loginjection.qlref: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Contributor

@lcartey lcartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update .github/workflows/javascript.sarif.expected, otherwise looks good to me.

@jeongsoolee09 jeongsoolee09 requested a review from lcartey January 7, 2025 20:46
@lcartey lcartey merged commit fe6937a into main Jan 7, 2025
5 checks passed
@lcartey lcartey deleted the jeongsoolee09/remove-loginjection-single-file branch January 7, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants