CDL: Improve performance by simplifying CDS location identification #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can assume that the path in the cds.json is relative to the repository root, as that is the directory the CDS compiler is run from.
In our testing framework we don't always have the .cds file indexed so we can't guarantee the presence of the File entry. Instead, compose the path using the sourceLocationPrefix, which will be robust to whether the .cds file was indexed or not.
|
Thank you! Question: Did the previous code require a trip to the disk from computing the absolute path? |
|
Previously, it looked up the |
- Index the .cds files in addition to the .cds.json files - Run the cds compiler at the appropriate path
|
LGTM, thank you! |
jeongsoolee09
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can assume that the path in the cds.json is relative to the repository root, as that is the directory the CDS compiler is run from.