Fix for powerpc and POWER9 indirect type 1 scom accesses #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Neuling <[email protected]>
Without this we get this on gcc 6.3:
misc.c:261:29: error: ‘cpuid_params’ defined but not used [-Werror=unused-const-variable=]
MAKE_PREREQ_PARAMS_VAR_ARGS(cpuid_params, 3, 4, "<cpu> <function> [index]", 0);
^
Signed-off-by: Michael Neuling <[email protected]>
Skiboot recently added support for type 1 indirect scom addresses. skiboot commit is here: commit 74311a97190d33e3753dc09a5fe6064120c8363a Author: Michael Neuling <[email protected]> xscom: Add indirect form 1 scoms This now uses the whole top nibble of the scom address to determine the indirection type. As a consequence, the bit mangling for the kernel interface needs to be updated (although it's backwards compatible) due to kernel commit. commit 517c27570cf38f182e7a688d50a9b978333f8ea8 Author: Michael Neuling <[email protected]> powerpc/powernv: Fix XSCOM address mangling for form 1 indirect This borrows the code from skiboot scom utils to add address mangling. Code is from skiboot commit: commit 034d545b1503bf3980c290c361ed1a99ce9d308d Author: Michael Neuling <[email protected]> external: Update xscom utils for type 1 indirect accesses Signed-off-by: Michael Neuling <[email protected]>
|
Looks like this repo is abandoned. So I merged the request to my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for powerpc and an update for POWER9.