Skip to content

Item Resource dropdown: accessibility and layout fixes#867

Merged
thostetler merged 3 commits into
adsabs:masterfrom
shinyichen:item-res-dropdowns-a11y
May 19, 2026
Merged

Item Resource dropdown: accessibility and layout fixes#867
thostetler merged 3 commits into
adsabs:masterfrom
shinyichen:item-res-dropdowns-a11y

Conversation

@shinyichen
Copy link
Copy Markdown
Member

  • The tooltip was causing the dropdown menus to be no longer accessible by keyboard.
    • Move the tooltip from the menu to the icon
  • Fix inconsistent menu icons size and layout

Before:
Screenshot 2026-05-14 at 3 00 48 PM

After:
Screenshot 2026-05-14 at 3 01 04 PM

@shinyichen shinyichen requested a review from thostetler May 14, 2026 22:02
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.7%. Comparing base (5a4245b) to head (43c672d).

Files with missing lines Patch % Lines
...mponents/ResultList/Item/ItemResourceDropdowns.tsx 89.5% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #867     +/-   ##
========================================
+ Coverage    62.7%   62.7%   +0.1%     
========================================
  Files         323     323             
  Lines       38011   38015      +4     
  Branches     1723    1725      +2     
========================================
+ Hits        23802   23815     +13     
+ Misses      14169   14160      -9     
  Partials       40      40             
Files with missing lines Coverage Δ
...mponents/ResultList/Item/ItemResourceDropdowns.tsx 79.2% <89.5%> (+0.4%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thostetler thostetler merged commit 2289bc1 into adsabs:master May 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants