Report query memory allocation in response body#260
Open
JCRPaquin wants to merge 3 commits into
Open
Conversation
tjacovich
reviewed
May 22, 2026
tjacovich
left a comment
tjacovich
left a comment
There was a problem hiding this comment.
I think this all looks reasonable. Just a comment on explaining what the commented line is and why it is commented out.
There was a problem hiding this comment.
Do we want to add a comment that describes this line and why it is currently excluded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We've had issues with searchers running out of memory while handling standard traffic. Our current observability around Solr is insufficient to help us track down offending requests without testing individual queries.
By adding memory reporting per-query, we hope to capture long tail queries that can be quite costly, as well as allocate resource units to different query types to better rate-limit incoming load.
What?
Adds per-thread allocation tracking and uses it to report per-query memory allocations. This PR also removes pre-allocation from second-order operators.