Add more informative 401 error.#19
Merged
tjacovich merged 5 commits intoadsabs:mainfrom Jun 12, 2025
Merged
Conversation
femalves
approved these changes
Jun 11, 2025
Pull Request Test Coverage Report for Build 15617276708Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
tjacovich
commented
Jun 12, 2025
| @@ -259,6 +260,10 @@ def _construct_remote_url(self) -> str: | |||
| class GatewayResourceProtector(ResourceProtector): | |||
| def raise_error_response(self, error): | |||
| body = json.dumps(dict({"message": error.description})) | |||
Contributor
Author
There was a problem hiding this comment.
The reason for the special handling is because the Bearer:TOKEN doesn't register as a Bearer token so authlib throws an UnsupportedTokenTypeError and that does not have a description so the body of the error is empty without additional handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a more verbose 401 error for users who may be using the old Authorization syntax.