Skip to content

Further limit bib data fields. Special Characters from abstracts#16

Merged
tjacovich merged 11 commits into
adsabs:mainfrom
tjacovich:further-limit-bib-data-fields
Aug 7, 2025
Merged

Further limit bib data fields. Special Characters from abstracts#16
tjacovich merged 11 commits into
adsabs:mainfrom
tjacovich:further-limit-bib-data-fields

Conversation

@tjacovich
Copy link
Copy Markdown
Collaborator

In order to deal with corner case data mismatches between our dev and prod environments, we have removed additional fields from the hashed bib_data. We are also removing all html tags, as well as special characters from the abstracts.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 6, 2025

Pull Request Test Coverage Report for Build 16788219952

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.857%

Totals Coverage Status
Change from base Build 16301190548: 0.2%
Covered Lines: 275
Relevant Lines: 293

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@mugdhapolimera mugdhapolimera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need a few more test cases to check if the special character handling behaves as expected

Comment thread tests/test_scix_id.py
Comment thread tests/test_scix_id.py Outdated
Copy link
Copy Markdown
Contributor

@mugdhapolimera mugdhapolimera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, added a few more thought experiments!

Comment thread SciXPipelineUtils/scix_id.py
Comment thread SciXPipelineUtils/scix_id.py
Comment thread tests/test_scix_id.py
Copy link
Copy Markdown
Contributor

@mugdhapolimera mugdhapolimera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tjacovich tjacovich merged commit e0228e9 into adsabs:main Aug 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants