Skip to content

added logging to trace scix id collisions #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mugdhapolimera merged 1 commit into from
Apr 9, 2026
Merged

added logging to trace scix id collisions #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 43 additions & 3 deletions adsmp/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,23 @@ def update_storage(self, bibcode, type, payload):
session.add(ChangeLog(key=bibcode, type=type, oldvalue=oldval))
record.updated = now
out = record.toJSON()
attempted_scix_id = None
try:
session.flush()
if not record.scix_id and record.bib_data:
record.scix_id = "scix:" + str(self.generate_scix_id(record.bib_data))
attempted_scix_id = "scix:" + str(self.generate_scix_id(record.bib_data))
record.scix_id = attempted_scix_id
out = record.toJSON()
session.commit()
return out
except exc.IntegrityError:
self.logger.exception('error in app.update_storage while updating database for bibcode {}, type {}'.format(bibcode, type))
except exc.IntegrityError as e:
session.rollback()
if attempted_scix_id:
self.log_scix_id_collision(bibcode, attempted_scix_id, e)
else:
self.logger.exception(
'IntegrityError in update_storage for bibcode %s, type %s '
'(not a scix_id collision)', bibcode, type)
raise

def generate_scix_id(self, bib_data):
Expand All @@ -194,6 +201,39 @@ def generate_scix_id(self, bib_data):
user_fields = None
return scix_id.generate_scix_id(bib_data, user_fields = user_fields)

def log_scix_id_collision(self, bibcode, attempted_scix_id, original_error=None):
Comment thread
tjacovich marked this conversation as resolved.
"""Query the database for the record that already holds attempted_scix_id
and log both the existing and new (bibcode, scix_id) pairs so curators
can identify which records are clashing."""
try:
with self.session_scope() as session:
existing = session.query(Records).filter_by(scix_id=attempted_scix_id).first()
if existing:
self.logger.error(
'SciX ID collision detected: '
'existing record in DB: (bibcode=%s, scix_id=%s), '
'new record that failed to commit: (bibcode=%s, scix_id=%s). '
'Original error: %s',
existing.bibcode, existing.scix_id,
bibcode, attempted_scix_id,
original_error
)
else:
Comment thread
mugdhapolimera marked this conversation as resolved.
self.logger.error(
'IntegrityError for bibcode %s with scix_id %s, '
'but no existing record found with that scix_id '
'(possible race condition or other constraint violation). '
'Original error: %s',
bibcode, attempted_scix_id,
original_error
)
except Exception:
self.logger.exception(
'Failed to query database for scix_id collision details '
'(bibcode=%s, attempted_scix_id=%s)',
bibcode, attempted_scix_id
)

def delete_by_bibcode(self, bibcode):
with self.session_scope() as session:
r = session.query(Records).filter_by(bibcode=bibcode).first()
Expand Down
14 changes: 8 additions & 6 deletions adsmp/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,14 @@ def task_update_scixid(bibcodes, flag):
if flag == 'update':
if not r.scix_id:
if r.bib_data:
r.scix_id = "scix:" + app.generate_scix_id(r.bib_data)
attempted_scix_id = "scix:" + app.generate_scix_id(r.bib_data)
r.scix_id = attempted_scix_id
try:
session.commit()
logger.debug('Bibcode %s has been assigned a new scix id: %s', bibcode, r.scix_id)
except exc.IntegrityError:
logger.exception('error in app.update_storage while updating database for bibcode %s', bibcode)
except exc.IntegrityError as e:
session.rollback()
app.log_scix_id_collision(bibcode, attempted_scix_id, e)
else:
r.scix_id = None
session.commit()
Expand All @@ -254,13 +255,14 @@ def task_update_scixid(bibcodes, flag):
if flag == 'force':
if r.bib_data:
old_id = r.scix_id
r.scix_id = "scix:" + app.generate_scix_id(r.bib_data)
attempted_scix_id = "scix:" + app.generate_scix_id(r.bib_data)
r.scix_id = attempted_scix_id
try:
session.commit()
logger.debug('Bibcode %s scix_id changed from %s to %s', bibcode, old_id, r.scix_id)
except exc.IntegrityError:
logger.exception('error in app.update_storage while updating database for bibcode %s', bibcode)
except exc.IntegrityError as e:
session.rollback()
app.log_scix_id_collision(bibcode, attempted_scix_id, e)
else:
r.scix_id = None
session.commit()
Expand Down
Loading