Skip to content

Redesign match detail timeline rendering #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrunkhuman merged 9 commits into from
Mar 25, 2026
Merged

Redesign match detail timeline rendering #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a92776
Remove Timeline panel; merge events into score header and lineup anno…
adrunkhuman Mar 22, 2026
4dd9f2d
Refine score header alignment and lineup substitution display
adrunkhuman Mar 22, 2026
a7408b1
Rework lineup event display: dedicated event column near centre separ…
adrunkhuman Mar 22, 2026
99bb6de
Refine match detail layout: minute in center, slim card column
adrunkhuman Mar 22, 2026
b4081a4
Align HT/FT divider score with minute column
adrunkhuman Mar 22, 2026
0cccb03
Align event minutes with HT/FT divider score dash
adrunkhuman Mar 22, 2026
b19ab1a
Tighten score section gap and lineup name spacing
adrunkhuman Mar 22, 2026
c4a6ea1
Polish match detail timeline spacing and dividers
adrunkhuman Mar 25, 2026
c354422
Fix match detail event association edge cases
adrunkhuman Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/ui/fixture_navigation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package ui

import (
"context"
"fmt"
"testing"

tea "github.com/charmbracelet/bubbletea"
Expand Down Expand Up @@ -188,9 +189,9 @@ func TestMatchViewScrollKeysDoNotChangeFixture(t *testing.T) {
t.Fatalf("expected match load command on enter")
}
m, _ = updateModelWithMsg(t, m, cmd())
m.match.Events = make([]site.MatchEvent, 0, 60)
m.match.HomeLineup = make([]site.PlayerLine, 0, 60)
for i := 1; i <= 60; i++ {
m.match.Events = append(m.match.Events, site.MatchEvent{MinuteText: "1", TeamSide: "home", Kind: "SUB", Text: "event"})
m.match.HomeLineup = append(m.match.HomeLineup, site.PlayerLine{Name: fmt.Sprintf("Player%02d", i)})
}

m, cmd = updateModelWithMsg(t, m, tea.KeyMsg{Type: tea.KeyPgDown})
Expand Down
Loading