Add wide_schema to standard benchmark allowlist#10
Merged
Conversation
wide_schema is a bench.sh standard benchmark (added upstream in apache/datafusion#21970): `bench.sh data/run wide_schema`, backed by a gen_wide_data binary and sql_benchmarks/wide_schema query set. It was missing from the standard allowlist, so `run benchmark wide_schema` fell through to the wildcard criterion path and ran `cargo bench --bench wide_schema`, which has no such target and failed. Adding it to the standard list routes it to the bench.sh runner. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wide_schemais abench.shstandard benchmark added upstream in apache/datafusion#21970 (bench.sh data/run wide_schema, backed by agen_wide_databinary and asql_benchmarks/wide_schemaquery set — 1024-col × 256-file wide dataset vs an 8-col narrow baseline).It was missing from the standard allowlist, so
run benchmark wide_schema(e.g. on apache/datafusion#22829) fell through to the wildcard criterion path and rancargo bench --bench wide_schema— which has no such target — and failed with cargo's "available bench targets" dump.Changes
wide_schemato thestandardlist forapache/datafusionand theadriangb/datafusiontest fork inservices/controller.ts, routing it to thebench.shstandard runner.🤖 Generated with Claude Code