-
Couldn't load subscription status.
- Fork 25
Simplify cards json #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simplify cards json #620
Conversation
Removed conditionals and flattened properties to apply to all cards. Descriptions clarify nuance. Added image ratio and image proportions.
🦋 Changeset detectedLatest commit: 4554ce4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Run report for 4554ce45Total time: 3.7s | Comparison time: 4.8s | Estimated savings: 1s (22.0% faster)
Touched files |
🧩 Component Schema Changes ReportComponent Schemas Changed (0 added, 0 deleted, 1 updated)Original Branch: New Branch: 🚨 Breaking Changes DetectedThis PR introduces 1 breaking change(s) to component schemas. Please review carefully and ensure proper versioning. 💥 Breaking Updates
|
Added prop for styling and required needed to be updated to correct prop.
Add prop to allow for optional title and description within cards
- Add remark-frontmatter plugin to preserve YAML frontmatter - Update lint-staged config to use frontmatter plugin first - Fix changeset format to use patch version for schema fix
- Mark as patch version since this fixes a previous issue - Exclude changeset files from remark processing to preserve frontmatter - This resolves the CI/CD pipeline failure for PR #620
Removed conditionals and flattened properties to apply to all cards. Descriptions clarify nuance. Added image ratio and image proportions.
Description
Related Issue
Motivation and Context
Cards json was not being ingested properly into design table on v0 website due to unsupported conditional properties. Simplifies the schema to meet design intent. Relies more on descriptions for nuance between card variants.
How Has This Been Tested?
I validated the schema changes locally using the Moon workspace pipeline. After updating cards.json, I ran:
pnpm moon checkThis installed the pinned pnpm version (10.17.1), resolved workspace dependencies, and executed the configured validation tasks. The pipeline reported all checks passing, confirming that the updated schema is valid and doesn’t introduce breaking issues.
Screenshots (if appropriate):
Types of changes
Checklist: