feat(actionbar): new s2 migration #3657
+110
−84
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| "@spectrum-css/actionbar": major | ||
| --- | ||
|
|
||
| ### Actionbar S2 Migration | ||
|
|
||
| Action bar now has some updated colors, corner radius, and icons. There's a new look to the default and emphasized variants and each have a custom touch in both light and dark themes. | ||
|
|
||
| The emphasized has changed from an `accent` background color to a `neutral` background color. | ||
|
|
||
| #### New tokens | ||
|
|
||
| `--spectrum-actionbar-emphasized-actionbutton-label-color` | ||
| `--spectrum-actionbar-emphasized-icon-color` | ||
| `--spectrum-actionbar-minimum-width` | ||
| `--spectrum-actionbar-spacing-label-to-actiongroup` | ||
| `--spectrum-actionbar-spacing-action-group-edge` | ||
| `--spectrum-actionbar-close-button-to-counter` | ||
|
|
||
| #### New mods | ||
|
|
||
| `--mod-actionbar-minimum-width` | ||
| `--mod-actionbar-spacing-action-group-edge` | ||
| `--mod-actionbar-spacing-label-to-actiongroup` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -92,7 +92,7 @@ WithForcedColors.parameters = { | |||||
|
|
||||||
| // ********* DOCS ONLY ********* // | ||||||
| /** | ||||||
| * The emphasized action bar has a neurtral background that adds visual emphasis on the actions and selection. Use this for when the bar should call attention (e.g., floating in a table). | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| */ | ||||||
| export const Emphasized = BehavioralTemplate.bind({}); | ||||||
| Emphasized.tags = ["!dev"]; | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ export const Template = ({ | |
| }, context), | ||
| FieldLabel({ size: "s", label: "2 Selected" }, context), | ||
| ActionGroup({ | ||
| customClasses: [`${rootClass}-actiongroup`], | ||
| size: "m", | ||
| areQuiet: true, | ||
| staticColor: isEmphasized ? "white" : undefined, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the "custom touch" in light and dark themes? I didn't notice any theme specific CSS in the PR.