feat(storybook): custom properties panel #3166
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0dbf6f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
3 times, most recently
from
2ed616c to
e1f7a95
Compare
castastrophe
added
skip_vrt
|
🚀 Deployed on https://pr-3166--spectrum-css.netlify.app |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
e1f7a95 to
27b6165
Compare
File metricsSummaryTotal size: 2.24 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
7 times, most recently
from
754b512 to
59656d1
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
59656d1 to
4c2f600
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
4c2f600 to
d497927
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
d497927 to
82d2f9e
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
from
eb20c09 to
3d14fcc
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
3 times, most recently
from
e66a6ff to
df9d5cc
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
2 times, most recently
from
2eebf01 to
711d4cd
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
df9d5cc to
ff03881
Compare
castastrophe
force-pushed
the
main
branch
10 times, most recently
from
c68f4e3 to
d2272ea
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
3 times, most recently
from
15b85cf to
4d403a2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -25,6 +25,7 @@ export const AssetListItem = ({ | |||
| isBranch = false, | |||
| onclick = () => {}, | |||
| } = {}, context = {}) => html` | |||
| ${when(styles, () => html`<style>${styles}</style>`)} | |||
| @@ -25,6 +25,7 @@ | |||
| isBranch = false, | |||
| onclick = () => {}, | |||
| } = {}, context = {}) => html` | |||
| ${when(styles, () => html`<style>${styles}</style>`)} | |||
| @@ -6,6 +6,11 @@ import packageJson from "../package.json"; | |||
| import { CheckboxGroup } from "./checkbox.test.js"; | |||
| import { AllVariantsCheckboxGroup, DocsCheckboxGroup, Template } from "./template.js"; | |||
|
|
|||
| // Local assets to render the component styles and structure | |||
| import styles from "../index.css?inline"; | |||
| import metadata from "../dist/metadata.json"; | |||
There was a problem hiding this comment.
🚫 [eslint] reported by reviewdog 🐶
Parsing error: Identifier 'metadata' has already been declared
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
3 times, most recently
from
b5079ad to
4653ea4
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
--- Co-authored-by: TarunAdobe <[email protected]>
* docs(assetcard): remove MDX file - adds some missing documentation regarding stories, classes and custom properties - corrects sentence-casing of story names * docs(avatar): remove MDX file - adds some missing documentation regarding stories - reorganizes some information to sit with appropriate story/variant - migrates documentation from MDX file to the stories file instead * chore(avatar): fix disabled test arguments * docs(badge): remove MDX file - adds notice badge variants to semantic story - adds sizing story to docs page - migrates documentation in MDX to stories.js instead * docs(badge): pr fixes - remove empty doc block line - remove html wrapper in favor of content array - add notice badge to test coverage
Expanding the existing themes system to support the new S2 mappings. --- Co-authored-by: castastrophe <[email protected]> Co-authored-by: Patrick Fulton <[email protected]> Co-authored-by: Cory Dransfeldt <[email protected]> Co-authored-by: Aziz Ramos <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: Rise Erpelding <[email protected]> Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Dragan Eror<[email protected]>
Expanding the existing themes system to support the new S2 mappings. --- Co-authored-by: castastrophe <[email protected]> Co-authored-by: Patrick Fulton <[email protected]> Co-authored-by: Cory Dransfeldt <[email protected]> Co-authored-by: Aziz Ramos <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: Rise Erpelding <[email protected]> Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Dragan Eror<[email protected]>
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
4653ea4 to
0dbf6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new custom properties panel to the development preview pages for each component that surfaces the modifiable custom properties as sourced from the metadata/metadata.json file (note that this is not a live updated list because metadata.json is not generated by storybook).
This panel allows a visitor to put in their own values and see how it impacts the styling of the component in the view panel.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
--mod-accordion-background-color-defaultentry; expect to see the background color of the accordion to update live.To-do list