-
Notifications
You must be signed in to change notification settings - Fork 14
feat: site sandbox configuration #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kanishkavijay39
wants to merge
16
commits into
main
Choose a base branch
from
feature/site-sandbox-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
db8c339
wip: sandbox audit configuration - adding initial changes
4f5f0f6
feat: add sandbox audit configuration support
499c6f1
fix: regenerate package-lock.json to resolve CI build failure
4f00e5e
fix: Update Configuration model to use proper attribute accessors for…
3820814
Merge main branch to get updated ESLint configuration and dependencies
ebe9581
docs: Add detailed comment to updateSandboxAuditConfig method
0b776e1
docs: Add ESLint 9 compatibility note to updateSandboxAuditConfig
f8730f8
feat: add hasSandboxAudits() encapsulation method and comprehensive J…
9b6444f
feat: simplify sandbox audit configuration and fix removal logic
0d90593
Merge remote-tracking branch 'origin/main' into feature/site-sandbox-…
02767dc
feat: add sandbox audit configuration support
8880a0b
cleanup: remove unrelated files from sandbox configuration feature
561a522
cleanup: remove remaining unrelated test files
5453635
refactor: change 'expire' to 'cooldownHours' for sandbox audit config…
79e2750
restore: bring back docs/API.md file that was accidentally emptied
780a452
fix(configuration): remove enabledAudits wrapper from sandbox configu…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the list be filtered by enabled true, according to the schema https://github.com/adobe/spacecat-shared/pull/941/files#diff-ec6a8162056224108b6fc55e86bf6d58298ed01c9cd75a0bb024369f6356b49bR52 ?
Same for
isAuditEnabledForSandboxbelow.