Skip to content

fix: removed bundles if urls array is empty #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: removed bundles if urls array is empty #1064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebb0859
fix: removed bundles if urls array is empty
sahil9001 Oct 29, 2025
0c7fd02
feat: installed deps
sahil9001 Oct 29, 2025
45f3a9d
chore: fixed package-lock.json
sahil9001 Oct 29, 2025
053d322
Merge remote-tracking branch 'origin/main' into SITES-36827
sahil9001 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/spacecat-shared-rum-api-client/src/functions/reports/optimization/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function initializeDataChunks(bundles, options = {}) {
const validBundles = (!bundles || !Array.isArray(bundles)) ? [] : bundles;

// Filter out bundles with missing or invalid URLs
const processedBundles = validBundles.filter((bundle) => bundle && bundle.url);
const processedBundles = validBundles.filter((bundle) => bundle?.url);

loadBundles(processedBundles, dataChunks);

Expand Down Expand Up @@ -143,9 +143,9 @@ export function calculateMetrics(chunk) {
*/
export function calculateTotals(timeSeriesData) {
return timeSeriesData.reduce((acc, data) => {
METRIC_NAMES.forEach((metric) => {
for (const metric of METRIC_NAMES) {
acc[metric] += (data[metric] || 0);
});
}
return acc;
}, METRIC_NAMES.reduce((acc, metric) => {
acc[metric] = 0;
Expand Down Expand Up @@ -178,13 +178,16 @@ export function filterBundles(bundles, opts) {
let filteredBundles = bundles;
if (outlierUrls && outlierUrls.length > 0) {
filteredBundles = filteredBundles
.filter((item) => item && item.url && !urlMatchesFilter(item.url, outlierUrls));
.filter((item) => item?.url && !urlMatchesFilter(item.url, outlierUrls));
}

// If urls filter is provided, keep only those URLs
if (urls && urls.length > 0) {
if (urls !== undefined && urls !== null) {
if (urls.length === 0) {
return [];
}
filteredBundles = filteredBundles
.filter((item) => item && item.url && urlMatchesFilter(item.url, urls));
.filter((item) => item?.url && urlMatchesFilter(item.url, urls));
}
return filteredBundles;
}
Expand Down
6 changes: 3 additions & 3 deletions packages/spacecat-shared-rum-api-client/test/optimization-metrics.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ describe('Optimization Report Metrics', () => {

const result = optimizationMetrics.handler(bundles, opts);

// Should include all bundles when URLs is empty
expect(result.pageViews.total).to.equal(100);
expect(result.conversions.total).to.equal(100);
// Should return empty results when URLs is empty
expect(result.pageViews.total).to.equal(0);
expect(result.conversions.total).to.equal(0);
});

it('should handle null options', () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/spacecat-shared-rum-api-client/test/optimization-utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,8 @@ describe('Optimization Utils', () => {

const result = filterBundles(testBundles, opts);

expect(result).to.deep.equal(testBundles);
// Should return empty array when URLs is empty
expect(result).to.deep.equal([]);
});

it('should handle null options', () => {
Expand Down