-
Notifications
You must be signed in to change notification settings - Fork 10
fix: Enable addition of Private Repos in Spacecat via Slack and add s… #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
#1372) Co-authored-by: Sagar Miglani <[email protected]>
|
/retest |
|
This PR will trigger a patch release when merged. |
| } | ||
|
|
||
| async function isOnboardedWithAemy(owner, repo, branch) { | ||
| const AEMY_ENDPOINT = `https://ec-xp-fapp-coordinator.azurewebsites.net/api/fn-ghapp/functions/get_installation_token/${owner}/${repo}/${branch}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we read it from an environment variable as done here. You may need to ask in the channel to add the environment variable in the api service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vdua, I was also thinking the same. Would you also happen to if env variable AEMY_API_KEY is available to spacecat-api-worker or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have access to check the env variables. Can you check in the slack channel.
|
|
||
| owner = repoInfo.owner.login; | ||
| repoName = repoInfo.name; | ||
| branch = branchInput || repoInfo.default_branch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bosschaert Since we are invoking AEMY shall we not get all the info from there itself ? Can we add a JIRA in the backlog for the same. We would need to know the default_branch in the long term.
…… (#1372)
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
Thanks for contributing!