Conversation
… migrations Add a bounded, skip-fast characterization-test step to the migration skill's per-finding apply loop (Step 5) for the before-eligible Java cascade patterns (guavaCache, scheduler, resourceChangeListener, eventListener/eventHandler). Each finding gets one fill-in test run green before the transform and re-run after, proving behavior is preserved — compile alone only proves it builds. replication and assetApi (execution-model changes) and all non-Java patterns stay compile/build-only. A standalone code-assessment run does not pin — this is a migration policy. Efficiency contract keeps effort nominal: one test per finding from a fixed skeleton, existing test harness only, stable-seam required, one attempt then skip, exactly two runs. Outcomes recorded inline in the Step 6 batch report; no new run-log or dependencies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Himanich
requested review from
abhishekgarg18,
akankshajain18,
pkumargaddam and
rombert
as code owners
September 21, 2026 09:06
… gating Review fixes on the characterization-tests reference: - Run command: drop `-q` (it suppresses BUILD SUCCESS and the Surefire `Tests run:` summary on a passing build, so a green run reads as a failure) and add `-DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false` (`-am` builds upstream reactor modules through the `test` phase, where the `-Dtest` filter matches nothing and Surefire otherwise fails them with "No tests matching pattern" before the target test runs). Both verified against a real 2-module reactor. - Harness gating: require io.wcm aem-mock only for the AemContext skeletons (B/C); skeleton A (guavaCache) needs only JUnit 5 + Mockito, so a missing io.wcm no longer forces a spurious no-test-harness skip. - Step 5: record `pin-skip: <reason>` to match Step 6 and the reference's outcome vocabulary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
10 tasks
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds behavior pinning (characterization tests) to the migration skill so Java migrations are verified for behavioral preservation, not just that they compile.
mvn compileproves the code builds; a pinned test proves it still does the same thing across the migration.Scope — migration only, 4 before-eligible patterns
guavaCache,scheduler,resourceChangeListener,eventListener/eventHandler— these preserve a behavioral seam a single test can bind to on both sides of the edit.replication(sync→async) andassetApi(in-JVM→external) change the execution model → no cheap characterization; they stay compile/build-only.htlLint, dispatcher, templates, legacy UI, vault deps,osgiConfig) are out of scope.code-assessmentrun on the same pattern does not pin — pinning is a migration policy for the riskier cross-version change.code-assessmentis untouched by this PR.How it works (migration Step 5)
Per finding: write one test → run green before the edit → transform → re-run after. Green = behavior preserved (
pinned); red after the edit = real regression → revert that finding's edit (pin-fail → reverted).Kept nominal / not overkill
io.wcmaem-mock) — never adds dependencies.Files
plugins/aem/cloud-service/skills/migration/references/characterization-tests.md(new — eligibility, efficiency contract, 3 skeletons)plugins/aem/cloud-service/skills/migration/SKILL.md(Branch B pointer, Step 5 pin + re-run, Step 6 report line)🤖 Generated with Claude Code