Skip to content

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Sep 22, 2025

Closes
found in testing

also fixes layout shift that would occur when an avatar action button became isPending
and adds size definition for a pending XS action button

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Comment on lines +306 to +307
'opacity',
'visibility'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how valid do we think this is? I'm not sure how else I would hide the component and since it doesn't change layout, seems mostly safe to allow setting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i feel like it should be fine? if we do add them, we should remember to add the properties to the list of supported css properties in the storybook intro docs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding these should be ok as well

@rspbot
Copy link

rspbot commented Sep 22, 2025

@snowystinger snowystinger changed the title fix: hide notification badge when button is pending fix: hide notification badge when button is pending and other pending fixes Sep 22, 2025
@rspbot
Copy link

rspbot commented Sep 22, 2025

@rspbot
Copy link

rspbot commented Sep 22, 2025

Comment on lines +306 to +307
'opacity',
'visibility'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding these should be ok as well

@LFDanLu LFDanLu added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 2a75be4 Sep 22, 2025
34 checks passed
@LFDanLu LFDanLu deleted the hide-notificationbadge-in-pending-buttons branch September 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants