-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: hide notification badge when button is pending and other pending fixes #8898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
'opacity', | ||
'visibility' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how valid do we think this is? I'm not sure how else I would hide the component and since it doesn't change layout, seems mostly safe to allow setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i feel like it should be fine? if we do add them, we should remember to add the properties to the list of supported css properties in the storybook intro docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding these should be ok as well
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
'opacity', | ||
'visibility' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding these should be ok as well
Closes
found in testing
also fixes layout shift that would occur when an avatar action button became isPending
and adds size definition for a pending XS action button
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: