Skip to content

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Sep 19, 2025

Found via chromatic

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check the RSP Accordion "with disabled disclosure" story, the disabled disclosure shouldn't display its contents. The tests and chromatic should cover the other cases

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Sep 19, 2025

@LFDanLu
Copy link
Member Author

LFDanLu commented Sep 19, 2025

@rspbot
Copy link

rspbot commented Sep 19, 2025

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember debating at one point if a disabled but open disclosure should render as open. I think we slightly leaned towards that was allowed. But I'm fine having it closed, I was very on the fence.

@LFDanLu
Copy link
Member Author

LFDanLu commented Sep 22, 2025

yeah, I wan't quite sure either but turns out that is how it had behaved on main previously

Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the issue #7444 debating whether a disabled disclosure should allow opened disclosures or closed disclosures. I think it's fine to have it close if disabled tho

@LFDanLu LFDanLu added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit abe2e95 Sep 22, 2025
35 checks passed
@LFDanLu LFDanLu deleted the disclosure_disable_fix branch September 22, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants