fix: Assorted new docs fixes from testing #8875
Merged
+139
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Sep 22, 2025
|
|
||
| // TODO: this causes a flash when the headings change size, maybe we just move this code | ||
| // to client and append suppressHydrationWarning to the h1s | ||
| export function TitleResizer() { |
There was a problem hiding this comment.
Want to use https://una.im/5-css-functions/#fluid-type if it's supported in the browser?
it's already in chrome Fyrd/caniuse#7368
|
Build successful! 🎉 |
…gation scroll positioning
… the images at small screen sizes
…r updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree
LFDanLu
changed the title
|
Build successful! 🎉 |
reidbarber
reviewed
Sep 29, 2025
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Sep 29, 2025
yihuiliao
previously approved these changes
Sep 30, 2025
snowystinger
previously approved these changes
Oct 2, 2025
|
Build successful! 🎉 |
reidbarber
reviewed
Oct 3, 2025
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
previously approved these changes
Oct 6, 2025
LFDanLu
commented
Oct 6, 2025
There was a problem hiding this comment.
I poked around with this example and decided to update it entirely since the Form + CheckboxGroup looks strange when the size was increased via the controls
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:EditableCell-EditableCell {
- align?: 'start' | 'center' | 'end' = 'start'
- children: ReactNode
- className?: ClassNameOrFunction<CellRenderProps> = 'react-aria-Cell'
- colSpan?: number
- id?: Key
- isSaving?: boolean
- onCancel: () => void
- onSubmit: () => void
- renderEditing: () => ReactNode
- showDivider?: boolean
- style?: StyleOrFunction<CellRenderProps>
- textValue?: string
-} |
reidbarber
approved these changes
Oct 7, 2025
snowystinger
approved these changes
Oct 8, 2025
LFDanLu
added a commit
that referenced
this pull request
Oct 9, 2025
* fix modal so it always appears over mobile header and fix dropzone width * add title font size resizing behavior to s2 docs * dont use useResizeObserver because we want to catch fonts changing * fix mobile header icon and library label * fix cross page anchor navigation scrolling and mobile cross page navigation scroll positioning * properly close mobile header menu when clicking on component card * making image coordinator example wrap to new row instead of squishing the images at small screen sizes * set a minwidth large enough so disallowEmptySelection have its label wrap * properly reobserve the new page post-navigation so the page nav picker updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree * remove broken title resizer code and fix rebase * restore styles * fix internationalized logo * add 404 page * forgot to remove test code * hide error page from search * update S2 popover example * update icon in example --------- Co-authored-by: Reid Barber <[email protected]>
devongovett
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix modal so it always appears over mobile header and fix dropzone width * add title font size resizing behavior to s2 docs * dont use useResizeObserver because we want to catch fonts changing * fix mobile header icon and library label * fix cross page anchor navigation scrolling and mobile cross page navigation scroll positioning * properly close mobile header menu when clicking on component card * making image coordinator example wrap to new row instead of squishing the images at small screen sizes * set a minwidth large enough so disallowEmptySelection have its label wrap * properly reobserve the new page post-navigation so the page nav picker updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree * remove broken title resizer code and fix rebase * restore styles * fix internationalized logo * add 404 page * forgot to remove test code * hide error page from search * update S2 popover example * update icon in example --------- Co-authored-by: Reid Barber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following:
✅ Pull Request Checklist:
📝 Test Instructions:
See the above
🧢 Your Project:
RSP