Skip to content

fix: Release audit #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ governing permissions and limitations under the License.
/*
Allow tab labels to wrap when TabList component has minWidth set.
*/
&.spectrum-Tabs--verticalWrap:not(.spectrum-Tabs--compact) .spectrum-Tabs-item {
&:not(.spectrum-Tabs--compact) .spectrum-Tabs-item {
display: flex;
align-items: center;
white-space: normal;
Expand Down
1 change: 0 additions & 1 deletion packages/@react-aria/calendar/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export {useCalendar} from './useCalendar';
export {useRangeCalendar} from './useRangeCalendar';
export {useCalendarGrid} from './useCalendarGrid';
export {useCalendarCell} from './useCalendarCell';
export {getEraFormat} from './utils';

export type {AriaCalendarProps, AriaRangeCalendarProps, CalendarProps, DateValue, RangeCalendarProps} from '@react-types/calendar';
export type {CalendarAria} from './useCalendarBase';
Expand Down
6 changes: 3 additions & 3 deletions packages/@react-spectrum/s2/src/Calendar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
RangeCalendarStateContext,
Text
} from 'react-aria-components';
import {AriaCalendarGridProps, getEraFormat} from '@react-aria/calendar';
import {AriaCalendarGridProps} from '@react-aria/calendar';
import {baseColor, focusRing, lightDark, style} from '../style' with {type: 'macro'};
import {
CalendarDate,
Expand Down Expand Up @@ -363,11 +363,11 @@ export const CalendarHeading = (): ReactElement => {
let calendarStateContext = useContext(CalendarStateContext);
let rangeCalendarStateContext = useContext(RangeCalendarStateContext);
let {visibleRange, timeZone} = calendarStateContext ?? rangeCalendarStateContext ?? {};
let era: any = getEraFormat(visibleRange?.start) || getEraFormat(visibleRange?.end);
let currentMonth = visibleRange?.start ?? visibleRange?.end;
let monthFormatter = useDateFormatter({
month: 'long',
year: 'numeric',
era,
era: currentMonth && currentMonth.calendar.identifier === 'gregory' && currentMonth.era === 'BC' ? 'short' : undefined,
calendar: visibleRange?.start.calendar.identifier,
timeZone
});
Expand Down
7 changes: 2 additions & 5 deletions packages/@react-spectrum/tabs/src/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ function TabLine(props: TabLineProps) {
* A TabList is used within Tabs to group tabs that a user can switch between.
* The keys of the items within the <TabList> must match up with a corresponding item inside the <TabPanels>.
*/
export function TabList<T>(props: SpectrumTabListProps<T> & {wrap?: boolean}): ReactNode {
export function TabList<T>(props: SpectrumTabListProps<T>): ReactNode {
const tabContext = useContext(TabContext)!;
const {refs, tabState, tabProps, tabPanelProps} = tabContext;
const {isQuiet, density, isEmphasized, orientation} = tabProps;
Expand All @@ -288,8 +288,6 @@ export function TabList<T>(props: SpectrumTabListProps<T> & {wrap?: boolean}): R

let tabListclassName = classNames(styles, 'spectrum-TabsPanel-tabs');

const verticalWrap = props.wrap && orientation === 'vertical';

const tabContent = (
<div
{...stylePropsFinal}
Expand All @@ -303,8 +301,7 @@ export function TabList<T>(props: SpectrumTabListProps<T> & {wrap?: boolean}): R
{
'spectrum-Tabs--quiet': isQuiet,
'spectrum-Tabs--emphasized': isEmphasized,
['spectrum-Tabs--compact']: density === 'compact',
'spectrum-Tabs--verticalWrap': verticalWrap
['spectrum-Tabs--compact']: density === 'compact'
},
orientation === 'vertical' && styleProps.className
)
Expand Down
6 changes: 3 additions & 3 deletions packages/@react-types/checkbox/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export interface AriaToggleProps extends ToggleProps, FocusableDOMProps, AriaLab
'aria-controls'?: string
}

export interface CheckboxGroupProps extends ValueBase<string[]>, InputBase, InputDOMProps, LabelableProps, HelpTextProps, Validation<string[]> {}
export interface CheckboxGroupProps extends ValueBase<string[]>, Pick<InputDOMProps, 'name'>, InputBase, LabelableProps, HelpTextProps, Validation<string[]> {}

export interface CheckboxProps extends ToggleProps {
/**
Expand All @@ -74,9 +74,9 @@ export interface CheckboxProps extends ToggleProps {
isIndeterminate?: boolean
}

export interface AriaCheckboxProps extends CheckboxProps, AriaToggleProps {}
export interface AriaCheckboxProps extends CheckboxProps, InputDOMProps, AriaToggleProps {}

export interface AriaCheckboxGroupProps extends CheckboxGroupProps, DOMProps, AriaLabelingProps, AriaValidationProps, FocusEvents {}
export interface AriaCheckboxGroupProps extends CheckboxGroupProps, InputDOMProps, DOMProps, AriaLabelingProps, AriaValidationProps, FocusEvents {}

export interface AriaCheckboxGroupItemProps extends Omit<AriaCheckboxProps, 'isSelected' | 'defaultSelected'> {
value: string
Expand Down
14 changes: 4 additions & 10 deletions packages/@react-types/datepicker/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ interface DatePickerBase<T extends DateValue> extends DateFieldBase<T>, OverlayT
*/
firstDayOfWeek?: 'sun' | 'mon' | 'tue' | 'wed' | 'thu' | 'fri' | 'sat'
}
export interface AriaDatePickerBaseProps<T extends DateValue> extends DatePickerBase<T>, AriaLabelingProps, DOMProps {}
export interface AriaDatePickerBaseProps<T extends DateValue> extends DatePickerBase<T>, AriaLabelingProps, InputDOMProps, DOMProps {}

export interface DatePickerProps<T extends DateValue> extends DatePickerBase<T>, ValueBase<T | null, MappedDateValue<T> | null> {}
export interface AriaDatePickerProps<T extends DateValue> extends DatePickerProps<T>, AriaDatePickerBaseProps<T>, InputDOMProps {}
export interface AriaDatePickerProps<T extends DateValue> extends DatePickerProps<T>, AriaDatePickerBaseProps<T> {}

export type DateRange = RangeValue<DateValue>;
export interface DateRangePickerProps<T extends DateValue> extends Omit<DatePickerBase<T>, 'validate' | 'autoComplete'>, Validation<RangeValue<MappedDateValue<T>>>, ValueBase<RangeValue<T> | null, RangeValue<MappedDateValue<T>> | null> {
Expand All @@ -100,13 +100,7 @@ export interface DateRangePickerProps<T extends DateValue> extends Omit<DatePick
/**
* The name of the end date input element, used when submitting an HTML form. See [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#htmlattrdefname).
*/
endName?: string,
/**
* The `<form>` element to associate the input with.
* The value of this attribute must be the id of a `<form>` in the same document.
* See [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input#form).
*/
form?: string
endName?: string
}

export interface AriaDateRangePickerProps<T extends DateValue> extends Omit<AriaDatePickerBaseProps<T>, 'validate' | 'autoComplete'>, DateRangePickerProps<T> {}
Expand Down Expand Up @@ -137,7 +131,7 @@ interface SpectrumDatePickerBase<T extends DateValue> extends SpectrumDateFieldB
shouldFlip?: boolean,
/**
* A function to create a new [Calendar](https://react-spectrum.adobe.com/internationalized/date/Calendar.html)
* object for a given calendar identifier. This will be used for the popover calendar. If not provided, the
* object for a given calendar identifier. This will be used for the popover calendar. If not provided, the
* `createCalendar` function from `@internationalized/date` will be used.
*/
createCalendar?: (identifier: CalendarIdentifier) => ICalendar
Expand Down
4 changes: 2 additions & 2 deletions packages/@react-types/radio/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {
} from '@react-types/shared';
import {ReactElement, ReactNode} from 'react';

export interface RadioGroupProps extends ValueBase<string|null, string>, InputBase, InputDOMProps, Validation<string | null>, LabelableProps, HelpTextProps, FocusEvents {
export interface RadioGroupProps extends ValueBase<string|null, string>, InputBase, Pick<InputDOMProps, 'name'>, Validation<string | null>, LabelableProps, HelpTextProps, FocusEvents {
/**
* The axis the Radio Button(s) should align with.
* @default 'vertical'
Expand All @@ -55,7 +55,7 @@ export interface RadioProps extends FocusableProps {
isDisabled?: boolean
}

export interface AriaRadioGroupProps extends RadioGroupProps, DOMProps, AriaLabelingProps, AriaValidationProps {}
export interface AriaRadioGroupProps extends RadioGroupProps, InputDOMProps, DOMProps, AriaLabelingProps, AriaValidationProps {}
export interface SpectrumRadioGroupProps extends AriaRadioGroupProps, SpectrumLabelableProps, StyleProps, SpectrumHelpTextProps {
/**
* The Radio(s) contained within the RadioGroup.
Expand Down
7 changes: 1 addition & 6 deletions packages/@react-types/tabs/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,7 @@ export interface SpectrumTabsProps<T> extends AriaTabListBase, Omit<SingleSelect

export interface SpectrumTabListProps<T> extends DOMProps, StyleProps {
/** The tab items to display. Item keys should match the key of the corresponding `<Item>` within the `<TabPanels>` element. */
children: CollectionChildren<T>,
/**
* When `true`, tab labels will wrap if they exceed the TabList's width. Only supported in vertical orientation with `regular` density. For proper wrapping, set a `minWidth` on TabList.
* @default false
*/
wrap?: boolean
children: CollectionChildren<T>
}

export interface SpectrumTabPanelsProps<T> extends DOMProps, StyleProps {
Expand Down