Skip to content

fix(s2): add space between timefield and calendar in DateRangePicker #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Jul 16, 2025

noticed during testing, fixed to match design

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

go to DateRangePicker, select the Zoned story, and open the Popover. make sure that the spacing is correct between the calendar and timefields

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jul 16, 2025

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, verified against the figma (though technically the figma has 24 + 7 from the timefield's top label)

@yihuiliao yihuiliao added this pull request to the merge queue Jul 16, 2025
Merged via the queue into main with commit e1087ff Jul 16, 2025
33 checks passed
@yihuiliao yihuiliao deleted the fix-space-datetime branch July 16, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants