Fix: Enable tabbing to tag remove buttons #8002
Open
+294
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #7483 by improving keyboard accessibility for tag remove buttons.
Changes made:
keyboardNavigationBehavior: 'tab'
to useTagGroupdelete rowProps.onKeyDownCapture
from useTagexcludeFromTabOrder: true
from useTagThese changes allow users to tab from a tag to its remove button, making the remove functionality accessible via keyboard. Arrow keys still work for navigating between tags.
Before this fix, keyboard users couldn't access the remove buttons via tab navigation, making it impossible to remove tags using only a keyboard.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Thomson Reuters - Contributing to improve React Spectrum accessibility