Skip to content

fix: verdaccio main #7948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 18, 2025
Merged

fix: verdaccio main #7948

merged 7 commits into from
Mar 18, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 17, 2025 •
edited
Loading

Closes

Fix is derived from rust-lang/rust#91979
Options were:

  • use parcel workers 0
  • use parcel worker backend process
  • downgrade tailwind to 4.0.12

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger changed the title fix: verdaccio main [WIP]: fix: verdaccio main Mar 17, 2025
snowystinger
snowystinger commented Mar 18, 2025
View reviewed changes
scripts/verdaccio-build-icon-builder.sh
@@ -17,8 +17,6 @@ else
echo "Verdaccio is NOT running on port 4000."
fi

curl -s http://localhost:4000/@adobe/react-spectrum
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this log was just so big it was not worth keeping around all the time

@snowystinger snowystinger changed the title [WIP]: fix: verdaccio main fix: verdaccio main Mar 18, 2025
@rspbot
Copy link

rspbot commented Mar 18, 2025

Build successful! 🎉

@snowystinger
Revert "turn on verdaccio"
aa5d82a 
This reverts commit 3b3a974.
@rspbot
Copy link

rspbot commented Mar 18, 2025

Build successful! 🎉

@snowystinger snowystinger enabled auto-merge March 18, 2025 01:25
@snowystinger snowystinger added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit e00dc83 Mar 18, 2025
30 checks passed
@snowystinger snowystinger deleted the fix-main-verdaccio branch March 18, 2025 01:38
github-merge-queue bot pushed a commit that referenced this pull request Mar 18, 2025
@snowystinger
fix: verdaccio main (#7948)
8d47f7d 
* debugging circleci

* remove overly large log

* increase log verbosity

* see if pinning the tailwind version fixes the issue

* fix example build

* turn on verdaccio

* Revert "turn on verdaccio"

This reverts commit 3b3a974.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @rspbot @devongovett @LFDanLu