feat: Add moveBefore and moveAfter to useTreeData #7854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
commented
Mar 3, 2025
| // we don't copy child node references from parents inadvertently | ||
| if (keyArray.includes(child.key)) { | ||
| removedItems.push({...newMap.get(child.key)!, parentKey: toParent?.key ?? null}); | ||
| let {items: nextItems, nodeMap: nextMap} = updateTree(newItems, child.key, () => null, newMap); |
There was a problem hiding this comment.
there's an opportunity to optimize here if we rewrite updateTree a little so we don't generate a new array and new map for every single removal and instead batch the update. I've opted to get a working baseline based on existing functionality first though with tests.
## API Changes
@react-stately/data/@react-stately/data:TreeData TreeData <T extends {}> {
append: (Key | null, Array<{}>) => void
getItem: (Key) => TreeNode<{}> | undefined
insert: (Key | null, number, Array<{}>) => void
insertAfter: (Key, Array<{}>) => void
insertBefore: (Key, Array<{}>) => void
items: Array<TreeNode<{}>>
move: (Key, Key | null, number) => void
+ moveAfter: (Key, Iterable<Key>) => void
+ moveBefore: (Key, Iterable<Key>) => void
prepend: (Key | null, Array<{}>) => void
remove: (Array<Key>) => void
removeSelectedItems: () => void
selectedKeys: Set<Key>
update: (Key, {}) => void
} |
|
Resolution on this @reidbarber please merge these changes into your PR and we'll just consider them as part of that. We can close this PR once you do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5574
Matches the API for useListData and takes a target key instead of an index to simplify moving items around. Also accepts an array of keys to move in bulk.
Includes an error check to make sure you don't try to move an item inside itself.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: