Generate valid variable names from theme names and fix comma in output formatting #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: launch prep
Merge branch 'master' of github.com:adobe/leonardo
style: fixed issue with tabs indicator color fallback
feat: adding link to demo app in UI
Bumps [serialize-to-js](https://github.com/commenthol/serialize-to-js) from 3.0.0 to 3.0.2. - [Release notes](https://github.com/commenthol/serialize-to-js/releases) - [Commits](commenthol/serialize-to-js@v3.0.0...v3.0.2) Signed-off-by: dependabot[bot] <[email protected]>
style: Updated demo app to a calendar with more colors to demonstrate
style: updated styles of links
…o-js-3.0.2 build(deps): bump serialize-to-js from 3.0.0 to 3.0.2
feat: colorscale as HTML Canvas
style: dropdown width override to correct width
- @adobe/[email protected] - @adobe/[email protected]
- @adobe/[email protected] - @adobe/[email protected]
…ed with less than 100% saturation (#172)
- @adobe/[email protected] - @adobe/[email protected]
* added initial form fill for contrast. WCAG 2 formula works * added apca to bulk contrast Co-authored-by: Nathan Baldwin <[email protected]>
Changed saturation color space
- @adobe/[email protected] - @adobe/[email protected]
* explicit types location * initial commit * rm extra whitespace * add note for later * verbose FIXMEs * improve inline documentation * adjust some inline documentation * color string templates to provide some IDE hints * adjust whitespace * fix type union * fix apca-w3 incorrectly marked as devdep * rm unreferenced devdep * correct import and entry paths * "mjs" => "js" since package.json specifies "type" * adjust test file glob * add module declaration for chroma-js extension * add missing oklab/oklch string types * replace missing oklab/oklch colorspaces * update functional notation to reflect std per MDN
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- @adobe/[email protected] - @adobe/[email protected]
** Commit: Generate valid variable names from theme names and fix comma in output formatting** Implemented a JavaScript regex to sanitize theme names for use as variable names: - Replaces spaces, hyphens, plus signs, and other invalid characters with underscores. - Ensures adherence to JavaScript variable naming conventions. Addressed a missing comma in output formatting: - Added a comma between the "output" and "formula" elements for clarity and consistency.
Author
|
Adobe CLA Signed! |
fix comma position
GarthDB
force-pushed
the
main
branch
8 times, most recently
from
500acc1 to
ed3e3c3
Compare
2 tasks
Member
|
Moved work to #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented a JavaScript regex to sanitize theme names for use as variable names:
Addressed a missing comma in output formatting:
Motivation
Fix output