Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Party #273

Merged
merged 12 commits into from
Jun 19, 2023
Merged

Block Party #273

merged 12 commits into from
Jun 19, 2023

Conversation

amol-anand
Copy link
Collaborator

Adding card list block for Block Party

Description

  • Added a card-list block that takes in a json url and then pulls data from the JSON, builds the existing cards block using the content and replaces the content with the cards block

Related Issue

#272

Motivation and Context

This is in conjunction with a form that is created to collect submissions from the Franklin community. We need a way to lightly curate (approve) the submissions and then display them so that people can see what we would like to share from the community submissions.

How Has This Been Tested?

  1. Fill out this form.
  2. Approve the submission in the curated-list tab.
  3. Preview and see the new submission show up in this page (testing in my fork for now)

Before: https://main--helix-website--adobe.hlx.page/developer/block-party/submission
After: https://main--helix-website--amol-anand.hlx.page/drafts/amol/block-party

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] I have signed the Adobe Open Source CLA.
  • [ x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 12, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 12, 2023

Page Scores Audits Google
/drafts/amol/block-party PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 12, 2023

Page Scores Audits Google
/drafts/amol/block-party PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 13, 2023

Page Scores Audits Google
/drafts/amol/block-party PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 13, 2023

Page Scores Audits Google
/drafts/amol/block-party PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 14, 2023

Page Scores Audits Google
/drafts/amol/block-party PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Member

@dylandepass dylandepass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@amol-anand amol-anand merged commit 6ff2055 into adobe:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants