-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Party #273
Merged
Merged
Block Party #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
amol-anand
requested review from
trieloff,
rofe,
davidnuescheler and
dylandepass
June 14, 2023 16:07
dylandepass
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding card list block for Block Party
Description
Related Issue
#272
Motivation and Context
This is in conjunction with a form that is created to collect submissions from the Franklin community. We need a way to lightly curate (approve) the submissions and then display them so that people can see what we would like to share from the community submissions.
How Has This Been Tested?
Before: https://main--helix-website--adobe.hlx.page/developer/block-party/submission
After: https://main--helix-website--amol-anand.hlx.page/drafts/amol/block-party
Screenshots (if appropriate):
Types of changes
Checklist: