-
Notifications
You must be signed in to change notification settings - Fork 7
Removing the license-maven-plugin from the dependencies #10
Removing the license-maven-plugin from the dependencies #10
Conversation
|
|
mjacoby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be followed by an update to java-serializer repository to include the new version of java-model?
|
|
||
| <properties> | ||
| <revision>1.1.1</revision> | ||
| <revision>1.3.0-SNAPSHOT</revision> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the new version be 1.2.1 instead of 1.3.0 (latest released version is 1.2.0 and for some reason differs from version defined in pom)? There should not be any new or changed funtionality so I wouldn't clasify it as minor change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this PR it should be 1.2.1-SNAPSHOT. I really don't have a strong opinion on this but we should make sure it's consistent.
arnoweiss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We initially added it to check for licenses of transatory dependencies during development-time. Since the model has no dependencies, removing it is a good idea.
|
@alw-iwu AFAIK, this PR does not remove the plugin but only removes the "duplicate dependency" for the plugin which caused it to be included in the final package. However, I agree that this should be fixed but before merging we need to address the two issues I mentioned before
|
|
I am closing this PR as the fix has already happened in the new eclipse repo with eclipse-aas4j/aas4j#23 |
Relates to #9
The build without the dependency worked in my local setting so it seems like the declaration as a plugin is enough.