Fix #949: Remove plaintext password fallback, add rate limiting on admin login - #956
Open
munazzaghazali7-hash wants to merge 2 commits into
Open
Conversation
|
@munazzaghazali7-hash is attempting to deploy a commit to the adithyansubramani1-1657's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #949
Summary
api/controllers/adminController.jspreviously fell back to a plainpassword === ADMIN_PASSWORDstring comparison ifADMIN_PASSWORDwasn'ta bcrypt hash. Combined with no rate limiting on the login endpoint, this
meant a misconfigured (plaintext) admin password could be brute-forced
with unlimited attempts.
Changes
entirely. If
ADMIN_PASSWORDisn't a valid bcrypt hash, login now failsclosed (500) with a clear log message telling the operator how to
generate a proper hash, instead of silently comparing in plaintext.
(10 attempts / 15 min per IP) on the admin login route using
express-rate-limit, which was already a dependency but not wired up.POST /login.Breaking change
If an existing deployment has
ADMIN_PASSWORDset as plaintext, adminlogin will now fail with a 500 until it's replaced with a bcrypt hash.
This is intentional — plaintext admin passwords should not be supported.
To generate a hash:
```
node -e "console.log(require('bcryptjs').hashSync(process.argv[1], 12))" yourPassword
```
Testing
ADMIN_PASSWORD.ADMIN_PASSWORDis plaintext.