Fix/test app import mismatch - #927
Open
mrunalC27 wants to merge 3 commits into
Open
Conversation
|
@mrunalC27 is attempting to deploy a commit to the adithyansubramani1-1657's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #862.
api/index.jsexports the Express app as the default export (module.exports = app), buttests/api.test.jswas importing it as a named export (const { app } = require(...)), soappin the tests was alwaysundefined.Changes
tests/api.test.js: changed the import to match the actual export shape (const app = require('../api/index')).api/index.js: guardedstartServer(PORT)so it doesn't run whenNODE_ENV === 'test', preventing a real TCP port from binding during test runs (this was causing theTCPSERVERWRAPopen-handle warning and the "log after tests are done" warning).Went with fixing the test import rather than restructuring the
api/index.jsexport, sincevercel.jsonpoints@vercel/nodedirectly atapi/index.jsand expects a callable export — wrapping it in{ app, handler }would've broken the Vercel deployment path.Confirmed
tests/api.test.jsis the only consumer of this import.Testing
npm test— all 4 tests now pass, no open handles, no stray logs.