Skip to content

feat(tools): NinjaPear#6771

Open
joaopfg wants to merge 1 commit intoaden-hive:mainfrom
joaopfg:feat/ninjapear-tool
Open

feat(tools): NinjaPear#6771
joaopfg wants to merge 1 commit intoaden-hive:mainfrom
joaopfg:feat/ninjapear-tool

Conversation

@joaopfg
Copy link
Copy Markdown

@joaopfg joaopfg commented Mar 23, 2026

Description

Adds a new NinjaPear tool that integrates with the NinjaPear (Nubela) API for person and company enrichment. Supports looking up person/employee profiles by work email, name+employer, or employer+role, as well as retrieving company details, funding rounds, updates, customers, and competitors. Also exposes a free credit balance check endpoint.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

Related Issues

#6695

Changes Made

  • Added NinjaPearTool with 7 MCP-exposed tools: ninjapear_get_person_profile, ninjapear_get_company_details, ninjapear_get_company_funding, ninjapear_get_company_updates, ninjapear_get_company_customers, ninjapear_get_company_competitors, ninjapear_get_credit_balance
  • Added NINJAPEAR_CREDENTIALS credential spec with credit cost documentation and API key setup instructions
  • Registered the tool and credentials in their respective __init__.py files

Testing

Describe the tests you ran to verify your changes:

  • Unit tests pass (cd core && pytest tests/)
  • Lint passes (cd core && ruff check .)
  • Manual testing performed

Unit tests cover all 7 tool endpoints including success cases, authentication errors (401), rate limiting (429), out-of-credits (403), not-found (404), and deprecated endpoint (410) responses.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots (if applicable)

N/A

@github-actions
Copy link
Copy Markdown

PR Requirements Warning

This PR does not meet the contribution requirements.
If the issue is not fixed within ~24 hours, it may be automatically closed.

Missing: No linked issue found.

To fix:

  1. Create or find an existing issue for this work
  2. Assign yourself to the issue
  3. Re-open this PR and add Fixes #123 in the description

Exception: To bypass this requirement, you can:

  • Add the micro-fix label or include micro-fix in your PR title for trivial fixes
  • Add the documentation label or include doc/docs in your PR title for documentation changes

Micro-fix requirements (must meet ALL):

Qualifies Disqualifies
< 20 lines changed Any functional bug fix
Typos & Documentation & Linting Refactoring for "clean code"
No logic/API/DB changes New features (even tiny ones)

Why is this required? See #472 for details.

@github-actions github-actions bot added the pr-requirements-warning PR doesn't follow contribution guidelines. Please fix or it will be auto-closed. label Mar 23, 2026
@joaopfg joaopfg mentioned this pull request Mar 23, 2026
1 task
@github-actions github-actions bot removed the pr-requirements-warning PR doesn't follow contribution guidelines. Please fix or it will be auto-closed. label Mar 23, 2026
Copy link
Copy Markdown
Collaborator

@levxn levxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these fixes and push again

@joaopfg joaopfg force-pushed the feat/ninjapear-tool branch from ae5db34 to 53d5707 Compare March 26, 2026 19:11
@joaopfg
Copy link
Copy Markdown
Author

joaopfg commented Mar 26, 2026

@levxn Thanks, I applied the changes you proposed and squashed the commits. Please, give me a new review.

@joaopfg joaopfg requested a review from levxn March 26, 2026 19:16
Copy link
Copy Markdown
Collaborator

@levxn levxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is fine, tools test are placed properly now. Just the litellm version, that does not need any version change, existing one is already good and safe to use. Just change this and push it. You are good to go apart from that

@joaopfg joaopfg force-pushed the feat/ninjapear-tool branch from 638b877 to a97b9e5 Compare March 26, 2026 21:22
@joaopfg joaopfg requested a review from levxn March 26, 2026 21:26
Copy link
Copy Markdown
Collaborator

@levxn levxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge @TimothyZhang7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants