Support for non-geographic coordinates and ThinWalls rework #11
+1,076
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct singularity boundary point limit
Logical `has_lon_jumps` is used to decide if to use a simple average (fast) or a shorter-distance average (slow) for longitude. The switch controls `periodicity` input argument for __mean??_lon functions. Currently, longitude is judged to have jumps if 1. Two adjacent points have difference larger than 180 degrees. 2. The North Pole is within the domain but not at the boundaries. This commit should help speed up most of 2D interpolations.
Allow GMesh to work with other projections like polar stereographic. `lonlat` argument changes the meaning of self.lon and self.lat to x, y in any projections.
is_geo_coord is added as an optional argument in instantiation. If true, (default), lon and lat are of their literal meanings, which are geographic coordinates. If false, lon and lat are arbitrary x/y coordinates. When is_geo_coord is False, all interpolations options related to lon and lat are turned off, including refine_in_3d, pole singularity and periodical longitude. The simple flag enables refine and regrid with arbitrary map projection like polar stereographic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some (not very) recent changes
GMeshto support arbitrary x-y coordinates (like stereographic), as along as they are uniform.ThinWalls