fix: call UIImageView initializer on main thread #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves this issue: runtime: UI API called from background thread: UIImageView.init(image:) must be used from main thread only
|
Any update on merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABImageViewis instantiated outside theDispatchQueue.main.asynccallback in a background thread. This results in the following warning:runtime: UI API called from background thread: UIImageView.init(image:) must be used from main thread only.I've moved the
imageandimageViewinstances into the async callback/block. I'm also callingimageView.setupGestures()beforecompletion()instead of after (is that okay or is there a reason for calling it aftercompletion()?)