Fix viewport jump when placing first room on blank map#1
Merged
Conversation
The viewport was jumping unexpectedly when placing the first room on a blank map due to two interacting issues: 1. The mapOrigin (center of bounds used for coordinate centering) was recalculated every time map content changed. When the first room was added, mapOrigin shifted from (0,0) to the room's center, causing all render coordinates to shift while the view offset stayed the same. 2. The initial scale effect's guard ref was not set for blank maps, so when mapBounds transitioned from null to valid, auto-zoom triggered unexpectedly. Fixed by: - Making mapOrigin stable within a map session (only updates when the map file changes, not when content is edited) - Setting the initial scale guard for blank maps immediately, preventing auto-zoom when first geometry is added Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mapOriginstable within a map session (only updates when map file changes)Root Cause
Two interacting issues caused the viewport to jump:
mapBoundswent from null to validTest plan
🤖 Generated with Claude Code