Add RFC-6638 Schedule Agent Parameter #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 9, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 9, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in.
6 tasks
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 9, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 9, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 10, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. The `SCHEDULE-AGENT` tells the CalDav server that the invitation has been sent by the client (which is cal in this case), preventing the CalDav server to not send invitations itself. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 10, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. The `SCHEDULE-AGENT` tells the CalDav server that the invitation has been sent by the client (which is cal in this case), preventing the CalDav server to not send invitations itself. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 10, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. The `SCHEDULE-AGENT` tells the CalDav server that the invitation has been sent by the client (which is cal in this case), preventing the CalDav server to not send invitations itself. refs calcom#9485
dasJ
added a commit
to dasJ/cal.com
that referenced
this pull request
Oct 10, 2023
The `ics` package doesn't support setting the `SCHEDULE-AGENT` parameter, there is a PR (adamgibbons/ics#248), but it is not merged. This is a workaround that relies on the fact that the `ics` package does not properly escape the `name` field of the organizer. In a perfect world, they would merge the PR and create a new release, but this is unfortunately not the world we live in. The `SCHEDULE-AGENT` tells the CalDav server that the invitation has been sent by the client (which is cal in this case), preventing the CalDav server to not send invitations itself. refs calcom#9485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to add a schedule agent parameter which is used by tools like fastmail or sogo to determine if an email should be sent. (https://icalendar.org/CalDAV-Scheduling-RFC-6638/7-1-schedule-agent-parameter.html)
This leads to problems with tools like cal.com (calcom/cal.com#9485).
This PR adds the required options.
As my typescript skills are not really a thing, it would be nice to know how to run the tests. Or if somebody else could run them and let me know if everything is working as expected