-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Sd card usb presentation fixes #10645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sd card usb presentation fixes #10645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things. Want to document this behavior somewhere? Maybe the workflow markdown?
185841e
to
d5ca685
Compare
I added a paragraph to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional doc thing.
db41daf
to
edd4532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
SD card USB presentation
.h
-only compile optionCIRCUITPY_SDCARD_USB
, which will enable/disable presenting SD card as a USB MSC LUN.atmel-samd
due to some bug that causes USB disconnection. I tested most of the other ports, and they don't have this problem. I'll open a separate issue about this for fixing post 10.0.0.Prevent unneeded auto-reload
Technical debt found in passing
gc_ptr_on_heap()
instead ofgc_nbytes() > 0
when checking if an object on the heap. Will be slightly faster.supervisor/shared/usb/usb_msc_flash.c
so the editor does not mess up the indentation.