-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Initial support for ESP32-C3-Lyra-V2 dev board #10625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See https://docs.espressif.com/projects/esp-adf/en/latest/design-guide/dev-boards/user-guide-esp32-c3-lyra.html This commit adds support for the status LED. It's not 100% clear to me why the default neopixel_write implementation doesn't work, but it seems that deleting the RMT channel triggers some sort of glitch signal that clears the WS2812C LED. Tested on this board: - console/REPL over USB/UART (connection works but is not stable) - web interface and editor over wifi - audiomp3 playback (sounds terrible) - neopixel library
@tannewt Do you have a comment on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the board addition and the mention Dan. I've suggested a way to limit the changes to the board directory.
Turns out it was a workaround for a bad LED on one particular board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for more research on the NeoPixel.
The creation ID used here is not in https://github.com/creationid/creators/blob/main/creations/espressif.md#0x00c3_xxxx---c3-dev-boards . Could you open an PR there? Also I would say use a creation ID that is consecutive with other C3 boards.
I tried to copy the model based on |
We have people register creation ID's at https://github.com/creationid/ so we can keep track of them. Pretty quick to do -- you could look at some of the merged PR's for examples (and look at the README). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
See https://docs.espressif.com/projects/esp-adf/en/latest/design-guide/dev-boards/user-guide-esp32-c3-lyra.html This commit adds support for the status LED.
It's not 100% clear to me why the default neopixel_write implementation doesn't work, but it seems that deleting the RMT channel triggers some sort of glitch signal that clears the WS2812C LED.
Tested on this board:
Also ran builds for various boards with different mcu under
ports/espressif
to check that I didn't break other builds.