implement ColorHSV - #15
Open
EdJoPaTo wants to merge 1 commit into
Open
Conversation
EdJoPaTo
added a commit
to EdJoPaTo/esp-mqtt-neomatrix-text
that referenced
this pull request
May 12, 2020
EdJoPaTo
added a commit
to EdJoPaTo/esp-mqtt-neomatrix-text
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use ColorHSV with the Matrix I currently would try to use
matrix.ColorHSV(0). This currently falls back to the NeoPixel implementation which is using 24-bit colors instead of 16-bit colors.I used the working NeoPixel code and adapted it for 16-bit usage.
In order to test I compared expected values to calculated ones. Also I used it with a real NeoPixel Matrix which works well.